Add sign_raw() #50
Merged
Add sign_raw() #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MHHukiewitz
force-pushed
the
mhh-sign-raw
branch
from
efc0aa9
to
0fa24ce
Compare
|
Relies on #49 |
|
The diff looks good to me. Do we have any test on the new |
Squashed and pushed on master. Can you rebase on it ? |
MHHukiewitz
force-pushed
the
mhh-sign-raw
branch
from
0fa24ce
to
07bafca
Compare
|
As discussed, |
|
After suggestion by @hoh I changed the signature of As this involves a bit more invasive refactoring, I decided that it would only make sense to add more unit tests, especially to the non-existent Cosmos and Substrate (Polkadot) tests. |
hoh
reviewed
Aug 19, 2023
hoh
reviewed
Aug 25, 2023
…MNEMONIC_FILE to settings
MHHukiewitz
force-pushed
the
mhh-sign-raw
branch
from
d273303
to
bd6a170
Compare
MHHukiewitz
force-pushed
the
mhh-sign-raw
branch
from
80e99be
to
ec513ee
Compare
odesenfans
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseAccount.sign_raw()accepts raw bytes and outputs a signature as a string in the preferred encoding.This allows signing of arbitrary data besides Aleph messages, making it a useful tool in dApp development.